[ENH] Extend Extension class test suite#1560
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1560 +/- ##
==========================================
- Coverage 52.04% 52.01% -0.03%
==========================================
Files 36 36
Lines 4333 4333
==========================================
- Hits 2255 2254 -1
- Misses 2078 2079 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Error seems unrelated to the PR given all this PR does is extend the Edit: The tests pass locally. |
jgyasu
left a comment
There was a problem hiding this comment.
Looks good to me. I think we can merge this even if the the Extension is planned to be refactored.
|
@jgyasu the problem in fact was related to this PR, if |
fkiraly
left a comment
There was a problem hiding this comment.
Not ready to merge, please address test failures. Merging with test failures is not possible.
|
Test failures discussed here |
Metadata
Details
This PR adds unit tests for the OpenML Extension interface and for extension registry behavior. The tests added are the 7 tests mentioned in [ENH] Extension Module Tests (or Examples?) #1545
Previously, only the non-abstract registry helpers (
get_extension_by_model,get_extension_by_flow) were covered. The abstractExtensioninterface itself was not tested.